Release 1.5.9 #3333
Merged
Release 1.5.9 #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add some i18n text
…dax-fix-issue-2690
…dax-fix-issue-2690
…concerns to data, not presentation
… defaultValue
When the translation component is passed a defaultValue that matches an i18n key with
an object value, `i18next.t` returns `undefined` instead of the default value.
Our Translation component was then returning an empty string in place of the default value
for these translations. This commit fixes that and returns the defaultValue if `i18next.t` returns `undefined` // i18next returns 'undefined' if the default value happens to be the key for a set of definitions
Example of the issue
example en.json file
```
...
"components": {
"componentDef": "Translated Component Def"
}
```
In this case, a request for i18next.t("components", "defaultValue") will return undefined
but i18next.t("components.componentDef", "defaultValue") will return correctly
…-translation-component-undefined (fix): Translation component issue returning undefined instead of defaultValue
…e-merchant-shop-apps Fix: hide settings panels merchant shops
…flow-uniqueItem-_id-undefined-3104 Fix uniqueItem._id undefined
…into release-1.5.9
Ryan color type tweaks
Remove extraneous blank line
Checking if the variant belongs to current product
…footer-and-header Use React components for footer and header
fix order values store as string
…lFix fix Cart.getShippingTotalByShop and use it in Cart.getSubTotal and in…
Fixed indicating products that are invalid for publication
…ud-panel-to-react-3093 Convert TaxCloud panel to React
|
Are these new grey lines supposed to be here? Totally not testing this PR or nothing but.... |
|
🤔 Hmm.. @rymorgan any thoughts on that? |
|
They were there before but they are darker and thicker now? From
|
|
Word from @rymorgan is that's the intended result. Approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.5.9
Fixes
Refactors
Style