Optimize ListEx.Clone by using the is operator #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inconsistent indentation Add unit test for ListEx.Clone for Move on a plain List
glennawatson
approved these changes
Aug 1, 2020
|
The IL code that gets generated is the same between the two versions but your PR is worth it in terms of code simplification and the extra unit tests. Thanks for submitting. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inconsistent indentation
Add unit test for ListEx.Clone for Move on a plain List
What kind of change does this PR introduce?
Optimization/simplification and code cleanup.
What is the current behavior?
As expected
What is the new behavior?
Same but with cleaner/optimized code and more unit tests to prove it works.
What might this PR break?
Nothing
Please check if the PR fulfills these requirements
Other information: