Fix BindToObservableList: Previous values not being removed & sorting resets being ignored. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 2, 2020 11:33
…e when the change is at a new index due to sorting.
…t` via `BindToObservableList`
RolandPheasant
approved these changes
Sep 3, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is two bug fixes for the
BindToObservableListextension method.Improves unit tests to cover these situations.
What is the current behavior?
Currently if you make a change to a model in an observable list that causes the updated model to move to a new index, the previous model is not removed from its old index.
When using
.Sortand the reset threshold is hit, the observable list does not update it's data set because it did not receive a list of changes.What is the new behavior?
What might this PR break?
This should only fix.
Please check if the PR fulfills these requirements
Other information: