Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Update to rx 5.0.0 and .net 5 #440

Merged
merged 4 commits into from
Nov 26, 2020
Merged

Conversation

glennawatson
Copy link
Member

No description provided.

@RolandPheasant
Copy link
Collaborator

@glennawatson great work. One issue, is why are there so many whitespace changes?

@glennawatson
Copy link
Member Author

Brought into line with the same analyzer suite we use for the rest of the RXUI projects.

@glennawatson glennawatson marked this pull request as ready for review November 26, 2020 07:48
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #440 (cea5b18) into main (809e700) will increase coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   70.25%   71.39%   +1.13%     
==========================================
  Files         213      214       +1     
  Lines       11340    10560     -780     
==========================================
- Hits         7967     7539     -428     
+ Misses       3373     3021     -352     
Impacted Files Coverage Δ
src/DynamicData/Aggregation/AggregateEnumerator.cs 70.58% <ø> (ø)
src/DynamicData/Aggregation/AggregateItem.cs 38.46% <ø> (+2.74%) ⬆️
src/DynamicData/Aggregation/AggregationEx.cs 52.63% <ø> (-9.87%) ⬇️
src/DynamicData/Aggregation/Avg.cs 100.00% <ø> (ø)
src/DynamicData/Aggregation/AvgEx.cs 19.51% <ø> (-9.48%) ⬇️
src/DynamicData/Aggregation/CountEx.cs 25.00% <ø> (+6.81%) ⬆️
src/DynamicData/Aggregation/MaxEx.cs 81.48% <ø> (-1.86%) ⬇️
src/DynamicData/Aggregation/StdDev.cs 0.00% <ø> (ø)
src/DynamicData/Aggregation/StdDevEx.cs 0.00% <ø> (ø)
src/DynamicData/Aggregation/SumEx.cs 6.06% <ø> (-1.24%) ⬇️
... and 268 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809e700...cea5b18. Read the comment docs.

@glennawatson glennawatson merged commit 36d18e0 into main Nov 26, 2020
@glennawatson glennawatson deleted the glennawatson-update-net5 branch November 26, 2020 08:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants