Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IObservableList items as IReadOnlyList #912

Merged
merged 5 commits into from
Jun 29, 2024
Merged

IObservableList items as IReadOnlyList #912

merged 5 commits into from
Jun 29, 2024

Conversation

kronic
Copy link
Contributor

@kronic kronic commented Jun 4, 2024 •
edited by dwcullop
Loading

Changes the Items property in IObservableList<T> from IEnumerable<T> to IReadOnlyList<T>.

@JakenVeina JakenVeina added enhancement breaking change Items that contain a breaking change to the codebase labels Jun 5, 2024
@JakenVeina
Copy link
Collaborator

I'm down with the change, but I'd like a second opinion as well, on whether we're good with the breakage.

dwcullop
dwcullop approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@dwcullop dwcullop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an okay breaking change.

@RolandPheasant
Copy link
Collaborator

Looks fine to me

@RolandPheasant
Copy link
Collaborator

Dare I say, that we should probably to the same for cache.

@kronic
Copy link
Contributor Author

kronic commented Jun 5, 2024

@RolandPheasant ok

@JakenVeina
Copy link
Collaborator

@kronic Need conflicts resolved, if you're still interested in getting this merged.

@RolandPheasant RolandPheasant merged commit af2a29e into reactivemarbles:main Jun 29, 2024
1 check passed
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwcullop dwcullop dwcullop approved these changes

@RolandPheasant RolandPheasant Awaiting requested review from RolandPheasant

Assignees
No one assigned
Labels
breaking change Items that contain a breaking change to the codebase enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kronic @JakenVeina @RolandPheasant @dwcullop