Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Reduce the versions of dependencies #50

Merged
merged 1 commit into from
May 31, 2021
Merged

Housekeeping: Reduce the versions of dependencies #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ReactiveMarbles.NuGet.Helpers/NuGetPackageHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public static async Task<InputAssembliesGroup> DownloadPackageFilesAndFolder(
/// <param name="nugetSource">Optional v3 nuget source. Will default to default nuget.org servers.</param>
/// <param name="token">A optional cancellation token.</param>
/// <returns>The best matching PackageIdentity to the specified version range.</returns>
public static async Task<PackageIdentity> GetBestMatch(LibraryRange identity, PackageSource nugetSource = null, CancellationToken token = default)
public static async Task<PackageIdentity> GetBestMatch(LibraryRange identity, PackageSource? nugetSource = null, CancellationToken token = default)
{
if (identity == null)
{
Expand Down
8 changes: 6 additions & 2 deletions src/ReactiveMarbles.ObservableEvents.SourceGenerator/AnalyzerReleases.Shipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
; Shipped analyzer releases
; https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
## Release 1.0

### New Rules

Rule ID | Category | Severity | Notes
--------|----------|----------|--------------------
RXPHARM001 | Compiler | Warning |
2 changes: 2 additions & 0 deletions src/ReactiveMarbles.ObservableEvents.SourceGenerator/EventGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ private static bool GenerateEvents(
return true;
}

#pragma warning disable RS1024 // Compare symbols correctly
var processedItems = new HashSet<INamedTypeSymbol>(TypeDefinitionNameComparer.Default);
#pragma warning restore RS1024 // Compare symbols correctly

var fileType = isStatic ? "Static" : "Instance";

Expand Down
8 changes: 2 additions & 6 deletions ....ObservableEvents.SourceGenerator/ReactiveMarbles.ObservableEvents.SourceGenerator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,9 @@
<DevelopmentDependency>true</DevelopmentDependency>
</PropertyGroup>

<PropertyGroup>
<RestoreAdditionalProjectSources>https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json ;$(RestoreAdditionalProjectSources)</RestoreAdditionalProjectSources>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.10.0-3.final" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.10.0-3.final" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.8.0" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.8.0" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" PrivateAssets="all" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/ReactiveMarbles.ObservableEvents.Tests/ReactiveMarbles.ObservableEvents.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.10.0-3.final" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.9.0" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" PrivateAssets="all" />
<PackageReference Include="ICSharpCode.Decompiler" Version="7.1.0.6543" />
</ItemGroup>
Expand Down