Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve performance of ipv4 address formatting #262

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

bnbajwa
Copy link
Contributor

@bnbajwa bnbajwa commented Jan 10, 2025

SDB-8486

@bnbajwa bnbajwa requested a review from a team as a code owner January 10, 2025 15:27
@bnbajwa
Copy link
Contributor Author

bnbajwa commented Jan 10, 2025

unit tests already exist in Endpoint.ut.test

Performance benchmark:

NAME                                                   COUNT       MIN       %50       %95       %99     %99.9    %99.99
------------------------------------------------------------------------------------------------------------------------
format_ipv4_endpoint_libc                           25081856     0.092     0.117     0.127     0.182     0.251     0.307
format_ipv4_endpoint                               165123072     0.014     0.017     0.019     0.021     0.027     0.033

So new formatter is ~7 times faster

toolbox/net/Endpoint.cpp Show resolved Hide resolved
@bnbajwa bnbajwa enabled auto-merge (rebase) January 16, 2025 23:17
@bnbajwa bnbajwa merged commit e18a4dc into reactivemarkets:master Jan 16, 2025
5 checks passed
@bnbajwa bnbajwa deleted the logperf2 branch January 16, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants