Fix For Reactive Property with Nested Classes #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
reviewed
Jan 5, 2025
| parentInfo); | ||
| } | ||
|
|
||
| public static void GetParentClasses(ref List<string> parentClassDeclarations, TargetInfo? targetInfo) |
There was a problem hiding this comment.
doesn't need to be ref does it
glennawatson
reviewed
Jan 5, 2025
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| namespace TestNs | |||
| { | |||
| /// <summary> | |||
There was a problem hiding this comment.
I'm guessing the offset is just caused by a """ raw string literal, where the first line is not aligned with the ending quotes.
glennawatson
approved these changes
Jan 5, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix for #133
What is the current behavior?
When using the [Reactive] generator with nested classes, the parents are not generated
What is the new behavior?
When using the [Reactive] generator with nested classes, the parents are generated
What might this PR break?
fix for regression
Please check if the PR fulfills these requirements
Other information:
Fixes for [ObservableAsProperty] and [ReactiveCommand] will follow in separate PR's