feature: Added Splat.SimpleInjector #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a SimpleInjectorDependencyResolver adapter - Added unit tests - Added Splat.SimpleInjector to build.cake
glennawatson
approved these changes
Jan 20, 2019
RLittlesII
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds and Simple Injector implementation of IMutableDepedencyResolver as an adapter to splat.
What is the current behavior? (You can also link to an open issue here)
There is no Simple Injector adapter for splat.
What is the new behavior (if this is a feature change)?
There is a Simple Injector adapter for splat.
What might this PR break?
Itself.
Please check if the PR fulfills these requirements
Other information:
Simple Injector doesn't support named instances by default. I am not sure whether we should attempt a factory implementation to provide with this feature.
Related: #233