feature: Add NLog logging adapter #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
glennawatson
requested changes
Jan 20, 2019
src/Splat.NLog/NLogLogger.cs
Outdated
| _level = value; | ||
| foreach (var configurationLoggingRule in _inner.Factory.Configuration.LoggingRules) | ||
| { | ||
| configurationLoggingRule.SetLoggingLevels(RxUitoNLogLevel(value), global::NLog.LogLevel.Fatal); |
There was a problem hiding this comment.
Might be worth removing the RxUI reference in this class, just because we in theory trying to make it more "platform' agnostic in the splat package.
src/Splat.NLog/Helpers.cs
Outdated
| /// <remarks> | ||
| /// You should configure NLog prior to calling this method. | ||
| /// </remarks> | ||
| public static void UseNLogWithWrappingFullLogger() |
There was a problem hiding this comment.
Might be worth changing this to a extension method, with this IMutableDependencyResolver -- that way you can register it against different containers
Then it becomes
Locator.CurrentMutable.UseNLogWithWrappingFullLogger();
glennawatson
changed the title
| @@ -0,0 +1,17 @@ | |||
| <Project Sdk="MSBuild.Sdk.Extras"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net461;uap10.0.16299;MonoAndroid80;Xamarin.iOS10;netstandard2.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Only other suggestion I have is adding the platforms from the main Splat project. Not sure if its strictly necessary though since in theory I think .netstandard2.0/uap/net461 will be likely the only ones needed.
3 tasks
glennawatson
approved these changes
Jan 21, 2019
|
Awesome thanks @dpvreony |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Brings Splat.NLog into the main Splat repository
What is the current behavior? (You can also link to an open issue here)
Was being maintained externally
What is the new behavior (if this is a feature change)?
What might this PR break?
The build until the nuget package permissions are transferred. (not changed the build script)
Please check if the PR fulfills these requirements
Other information: