Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping Enable Analyser and Set level #935

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update Analyser configuration

What is the current behaviour?

Analyser mode is set but not turned on

What is the new behaviour?

Analyser mode and level is set and turned on

What might this PR break?

none expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #935 (7781847) into main (d26df92) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   75.11%   75.21%   +0.10%     
==========================================
  Files          92       92              
  Lines        4894     4894              
==========================================
+ Hits         3676     3681       +5     
+ Misses       1218     1213       -5     
Impacted Files Coverage Δ
src/Splat/Logging/FullLoggerExtensions.cs 28.57% <0.00%> (+0.95%) ⬆️
src/Splat/Logging/WrappingFullLogger.cs 65.58% <0.00%> (+1.29%) ⬆️
...ceMonitoring/DefaultFeatureUsageTrackingSession.cs 72.00% <0.00%> (+4.00%) ⬆️
src/Splat/Logging/WrappingPrefixLogger.cs 70.58% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26df92...7781847. Read the comment docs.

@glennawatson glennawatson merged commit fa2aed8 into main Jul 14, 2022
@glennawatson glennawatson deleted the CP_HousekeepingUpdateAnalyser branch July 14, 2022 17:24
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants