-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(wip) Update custom-dependency-inversion.md #255
Conversation
- Do not call InitializeSplat and InitializeReactiveUI because that will duplicate all Splat and ReactiveUI registrations. - Add sample implementation of using FuncDependencyResolver with NInject - Update implementation of IMutableDependencyResolver because two new interface members have been added.
Autofac doesn't allow Unregister per say so it's fine to just leave the exception there. That was what I intended in containers where it wasn't supported. |
input/docs/handbook/dependency-inversion/custom-dependency-inversion.md
Outdated
Show resolved
Hide resolved
Thanks for clarifying @glennawatson |
I think this relates to #134 |
Locator.Current = resolver; | ||
``` | ||
|
||
From this point on calls `Locator.Current` will go against your custom implementation! | ||
|
||
## Bonus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of calling this a bonus, which implies that it is an extra added bit to the auto fac code above. We should either move this to another page, or explicitly call out using a header tag that this is a different container.
Not sure, but maybe worth using the
|
Yeah. The suggestion for multiple pages is based on the current site paradigm and that it would make it easy to select a particular container if we explicity put it in their face. I am less concerned about how it is separated (pages, details, expanding buttons, hidden iframes), and more concerned about it being clearly marked that a specific code sample belongs to a specific container. |
Once someone does reactiveui/splat#233 this documentation will change drastically, so could be worthwhile keeping it on one page. |
Going to close this PR, thanks for the work @cabauman -- given now that @RLittlesII has put most of the major DI engines into Splat I don't think this one is as needed anymore. |
I'm not familiar with Autofac, so I just put placeholders for the unregister methods. Can someone add implementations?