Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Resources translated #243

Merged
merged 8 commits into from
Jun 21, 2019
Merged

External Resources translated #243

merged 8 commits into from
Jun 21, 2019

Conversation

zant
Copy link
Contributor

@zant zant commented Jun 17, 2019

Please review @carburo

@netlify
Copy link

netlify bot commented Jun 17, 2019

Deploy preview for es-reactjs ready!

Built with commit 9e1ed57

https://deploy-preview-243--es-reactjs.netlify.com

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @gonzarodriguezt! Thank you so much for your contribution. I pointed out a few things that I think should be addressed before merging. Feel free to reply when you don't agree.
Also, the title isn't translated.

@zant
Copy link
Contributor Author

zant commented Jun 20, 2019

Hey! Thank you for the comments!

Requests commited and title translation added. @carburo

@carburo carburo self-requested a review June 21, 2019 11:47
@carburo carburo merged commit 22cfdf9 into reactjs:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants