Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for home/examples #3

Merged
merged 9 commits into from
Feb 6, 2019
Merged

Add translations for home/examples #3

merged 9 commits into from
Feb 6, 2019

Conversation

ricglz
Copy link
Contributor

@ricglz ricglz commented Jan 31, 2019

No description provided.

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ricglz0201, looking good so far! I left a couple of minor comments though :).

@carburo carburo mentioned this pull request Feb 1, 2019
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ricglz0201!

Thanks for your first-time contribution, also, thank you for addressing all the requested changes that quick.

This PR looks good now. Will merge it right away.

Welcome to the team!

@alejandronanez alejandronanez merged commit 6f9118e into reactjs:master Feb 6, 2019
gaearon added a commit that referenced this pull request Apr 17, 2023
* Fix alternate lang tags

* prettier

* Scope down the change

---------

Co-authored-by: Dan Abramov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants