Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Concurrent Mode Introduction #276

Merged
merged 6 commits into from
Dec 26, 2019
Merged

Translate Concurrent Mode Introduction #276

merged 6 commits into from
Dec 26, 2019

Conversation

smikitky
Copy link
Member

Concurrent Mode - Introduction の翻訳です

  • concurrent mode の翻訳ですが「並列モード」にしてみました
  • experimental build は「実験的ビルド」にしました (Translate Release Channels #275 とも絡みますが)

@smikitky smikitky requested review from koba04 and potato4d November 22, 2019 03:38
@netlify
Copy link

netlify bot commented Nov 22, 2019 •
edited
Loading

Deploy preview for ja-reactjs ready!

Built with commit fe9b684

https://deploy-preview-276--ja-reactjs.netlify.com

@smikitky smikitky mentioned this pull request Nov 22, 2019
Closed
5 tasks
@koba04
Copy link
Member

koba04 commented Nov 26, 2019

すみません、今週時間を取るのが難しいので来週確認します🙏

koba04
koba04 reviewed Dec 3, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky
細かい言い回しなどばかりですがコメントしたので確認お願いします 🙏

koba04
koba04 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!!!👏 ありがとうございます！

@smikitky
Copy link
Member Author

smikitky commented Dec 25, 2019 •
edited
Loading

@potato4d @koba04 potato4d さんのレビュー待ちではあるのですが、お忙しいようですし、翻訳した人がメンテナ自身でもあるので、「2 名のメンテナの目を通した」ということで、このままマージしてもいいのかな…と思うのですが、如何でしょうか。Concurrent Mode は注目されている機能なのであまり長い間未翻訳なのも良くないですし。

@potato4d
Copy link
Member

@smikitky はい、大丈夫です🙇
ちょっと1月18日まで動けないので、問題なかったらマージしてください！

@koba04
Copy link
Member

koba04 commented Dec 26, 2019

👍 いいと思います！
（他のPRのレビューも進めます...）

@smikitky smikitky merged commit 3a433cb into master Dec 26, 2019
@smikitky smikitky deleted the tr/concurrent-intro branch December 26, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@potato4d potato4d Awaiting requested review from potato4d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smikitky @koba04 @potato4d