Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate hooks-state (Using the State Hook) #51

Merged
merged 4 commits into from
Feb 7, 2019
Merged

Translate hooks-state (Using the State Hook) #51

merged 4 commits into from
Feb 7, 2019

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Feb 3, 2019

First translation of hooks-state.md

@tesseralis tesseralis mentioned this pull request Feb 3, 2019
Closed
90 tasks
@smikitky smikitky requested a review from potato4d February 3, 2019 11:25
@koba04 koba04 requested review from koba04 and removed request for koba04 February 4, 2019 01:17
@koba04 koba04 added the 🚫 in intial review 初期レビューの真っ最中 label Feb 4, 2019
koba04
koba04 requested changes Feb 4, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしましたので確認お願いします 🙇

@koba04 koba04 removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 4, 2019
@smikitky
Copy link
Member Author

smikitky commented Feb 5, 2019

@koba04 丁寧なレビューありがとうございました！

@potato4d
Copy link
Member

potato4d commented Feb 5, 2019

次自分もこれ見ますねー。

potato4d
potato4d reviewed Feb 5, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました 👀
個人的にページ内のリンクの必須だと思っている(メンテナ以外が翻訳した場合に、後から気づくことが容易ではないため)ですが、意見をもらえるとありがたいです。

koba04
koba04 requested changes Feb 5, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点翻訳されていない文章があったのでそこだけお願いします！

@smikitky
Copy link
Member Author

smikitky commented Feb 5, 2019

@koba04 修正しました、「まとめ」のところがハイライトされていたので気づきませんでした…

@potato4d ページ内アンカーについては別 issue の通りです。他は対応しました。

@koba04
Copy link
Member

koba04 commented Feb 5, 2019

対応ありがとうございました！

@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

#91 でフックに関わる差分がマージされます。翻訳を修正するまでマージはお待ちください。

potato4d
potato4d approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです。Approve は出しておくので、タイミングをあわせてマージしてください 🙏

@smikitky smikitky merged commit 94fccbb into master Feb 7, 2019
@potato4d potato4d deleted the tr/hooks-state branch February 20, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@potato4d potato4d potato4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smikitky @potato4d @koba04