Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate "useInsertionEffect" #625

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Translate "useInsertionEffect" #625

merged 2 commits into from
Aug 6, 2023

Conversation

smikitky
Copy link
Member

No description provided.

@smikitky smikitky requested review from koba04 and potato4d July 16, 2023 04:59
@smikitky smikitky mentioned this pull request Jul 16, 2023
Open
@github-actions
Copy link

github-actions bot commented Jul 16, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

koba04
koba04 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!!!

#648 で変更・追加が入っているのでこの PR か #648 で対応が必要そうです。

@smikitky
Copy link
Member Author

smikitky commented Aug 3, 2023

さきに #648 をマージして、こちらは後で対応ということでお願いします

@koba04
Copy link
Member

koba04 commented Aug 3, 2023

mergeしました！

@smikitky smikitky requested a review from koba04 August 4, 2023 04:53
@smikitky
Copy link
Member Author

smikitky commented Aug 4, 2023

一応もう一度チェックをお願いします。"interleave" の辺り、解釈はこれで合ってますよね。

@smikitky smikitky closed this Aug 6, 2023
@smikitky smikitky reopened this Aug 6, 2023
@smikitky smikitky merged commit 72d2b79 into main Aug 6, 2023
@smikitky smikitky deleted the tr/useInsertionEffect branch August 6, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@potato4d potato4d Awaiting requested review from potato4d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smikitky @koba04