Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The one with hooks #162

Merged
merged 51 commits into from
Mar 15, 2019
Merged

The one with hooks #162

merged 51 commits into from
Mar 15, 2019

Conversation

kah-eek
Copy link

@kah-eek kah-eek commented Mar 12, 2019

No description provided.

Caique M. Oliveira added 16 commits March 9, 2019 12:08
make translation of 'What Are Hooks?' block
3ecad32
make translation of 'No Big Rewrites' block
3c69d0c
make translation of 'Can I Use Hooks Today?' block
07e9812
make translation of 'Tooling Support' block
3499459
make translation of 'What’s Next' block
ac40e5f
make translation of 'Testing Hooks' block
e17355a
make translation of 'Thanks' block
3670fe5
make translation of 'Installation' block
6aeb02a
make translation of 'ESLint Plugin for React Hooks' block
eef322a
make translation of 'Changelog (React)' block
ee9d976
change header from 'Obrigado' to 'Agradecimento'
7b40755
make translation of 'React DOM' block
d47a379
make translation of 'React Test Renderer' block
ebca37b
make translation of 'ESLint Plugin: React Hooks' block
c18e951
make translation of 'Hooks Changelog Since Alpha Versions' block
7104e2e
remove some comments on code
1b644c4
@kah-eek kah-eek mentioned this pull request Mar 12, 2019
Closed
45 tasks
@netlify
Copy link

netlify bot commented Mar 12, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 0f274aa

https://deploy-preview-162--pt-br-reactjs.netlify.com

@jhonmike jhonmike added the needs review A pull request ready to be reviewed label Mar 12, 2019
@kah-eek
Copy link
Author

kah-eek commented Mar 12, 2019

Hey guys! Where could I find the date of the article to translate it?
Example: "February 06, 2019 by Dan Abramov".

@jhonmike jhonmike added the blog Blog post translation label Mar 12, 2019
@jlucfarias
Copy link
Contributor

I think it's not translatable because, as you can see here and here, this information come from the database.

@halian-vilela
Copy link
Collaborator

@CaiqueMOliveira @John-Luke

Pessoal, podem falar português nas discussões ok?

Eu vou checar com o pessoal do React Core se há alguma maneira melhor de traduzir a data.

@kah-eek
Copy link
Author

kah-eek commented Mar 12, 2019

I think it's not translatable because, as you can see here and here, this information come from the database.

Ah sim! Obrigado @John-Luke ;)

@halian-vilela
Copy link
Collaborator

I think it's not translatable because, as you can see here and here, this information come from the database.

Ah sim! Obrigado @John-Luke ;)

O "by" dá pra traduzir com "por" aqui: https://github.com/reactjs/pt-BR.reactjs.org/blob/0e57e84754fa9711edb042ecc273c1c3281e70a3/src/components/MarkdownPage/MarkdownPage.js#L91

Eu to vendo com o pessoal do core se a gente consegue mudar o locale e o formato da data na query que é feita no outro arquivo.

Assim que obtiver uma resposta eu aviso vocês.

@jlucfarias
Copy link
Contributor

jlucfarias commented Mar 12, 2019 •
edited
Loading

Eu achei esse link que pode ajudar

No caso, só precisaria alterar a ordem do formato da data e adicionar o argumento locale: 'pt-br'

@halian-vilela
Copy link
Collaborator

halian-vilela commented Mar 12, 2019 •
edited
Loading

Eu achei esse link que pode ajudar

@John-Luke @CaiqueMOliveira

Fantástico, eu acho que isso solucionaria, temos que testar.

Mas de qualquer maneira o ideal é manter esse arquivo de tradução em separado desses ajustes. Se vcs quiserem (e puderem) ver isso agora, sugiro abrir uma PR separada pra tratar só disso e fazer as mundanças específicas nos 2 arquivos.

Caso não puderem agora, de noite eu dou uma olhada.

Tenho que voltar pro trampo aqui.

Abs!

@jlucfarias
Copy link
Contributor

Eu vou ter a tarde livre, então pode deixar que eu faço os ajustes nisso

felipemfp
felipemfp reviewed Mar 13, 2019
View reviewed changes
Copy link
Contributor

@felipemfp felipemfp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em geral, o que notei foi a utilização de "React Hooks" como algo singular, enquanto que a documentação original/oficial utiliza como uma coleção, ou seja, no plural.

felipemfp and others added 10 commits March 13, 2019 00:12
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
32790c1 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
6741c3a 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
7f19457 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
eec57c6 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
3ca1730 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
7d1b5df 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
b4b6b29 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
ada5120 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
4e9f710 
Bem observado, obrigado.

Co-Authored-By: CaiqueMOliveira <[email protected]>
@felipemfp
Update content/blog/2019-02-06-react-v16.8.0.md
40c9736 
Co-Authored-By: CaiqueMOliveira <[email protected]>
@kah-eek
Copy link
Author

kah-eek commented Mar 13, 2019

Em geral, o que notei foi a utilização de "React Hooks" como algo singular, enquanto que a documentação original/oficial utiliza como uma coleção, ou seja, no plural.

@felipemfp de fato não me atentei a estes aspectos. Falha minha :(
Mas agradeço por todas as sugestões, inclusive grande parte delas foram aceitas... caso encontre mais alguma, por favor, não deixe de mandar. Muito obrigado !! 👍

@jlucfarias jlucfarias mentioned this pull request Mar 13, 2019
Merged
kah-eek
kah-eek commented Mar 13, 2019
View reviewed changes
Copy link
Author

@kah-eek kah-eek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Após realizar grande parte das mudanças, acredito que esta versão já pode ser validada.

jhonmike
jhonmike requested changes Mar 14, 2019
View reviewed changes
@jhonmike jhonmike added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Mar 14, 2019
jhonmike
jhonmike previously approved these changes Mar 14, 2019
View reviewed changes
@jhonmike jhonmike merged commit ffcabd4 into reactjs:master Mar 15, 2019
@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemfp felipemfp felipemfp left review comments

@jhonmike jhonmike jhonmike approved these changes

Assignees
No one assigned
Labels
blog Blog post translation 🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kah-eek @jlucfarias @halian-vilela @jhonmike @felipemfp