Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Create a new React App page #18

Merged
merged 6 commits into from
Feb 9, 2019
Merged

Translate Create a new React App page #18

merged 6 commits into from
Feb 9, 2019

Conversation

mrcelo
Copy link
Contributor

@mrcelo mrcelo commented Feb 8, 2019

#1

@mrcelo mrcelo changed the title Add translation for Create a new React App page Translate Create a new React App page Feb 8, 2019
@mrcelo mrcelo mentioned this pull request Feb 8, 2019
Closed
90 tasks
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 8, 2019
klzns
klzns suggested changes Feb 8, 2019
View reviewed changes
glaucia86
glaucia86 requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrcelo algumas alterações a serem feitas.
Quando terminar colocar como 'Resolve Conversation' que analisaremos novamente as alterações e logo aprovação da sua contribuição. Muito obrigada.

klzns and others added 2 commits February 8, 2019 21:18
@klzns @mrcelo
Fix pronoun
9c94c96 
Co-Authored-By: mrcelo <[email protected]>
@klzns @mrcelo
Fix noun
82d7ef8 
Co-Authored-By: mrcelo <[email protected]>
glaucia86
glaucia86 approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @WendellAdriel @cezaraugusto could you see if it's okay?

@glaucia86 glaucia86 added needs resolution Something not defined that needs maintainers input needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
cezaraugusto
cezaraugusto reviewed Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @mrcelo! left some nits but overall this looks 👌

@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging needs resolution Something not defined that needs maintainers input labels Feb 9, 2019
cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mrcelo! way to go!

@cezaraugusto cezaraugusto merged commit af17c4e into reactjs:master Feb 9, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klzns klzns klzns requested changes

@glaucia86 glaucia86 glaucia86 approved these changes

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrcelo @klzns @glaucia86 @cezaraugusto @fjoshuajr