Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Components and Props #23

Merged
merged 10 commits into from
Feb 10, 2019
Merged

Translate Components and Props #23

merged 10 commits into from
Feb 10, 2019

Conversation

ifdiego
Copy link
Contributor

@ifdiego ifdiego commented Feb 9, 2019

Translating "Components and Props" to PT-BR.

Note:
On line 248, there is an external link to Pure Functions on Wikipedia.
I haven't found an article in Portuguese Wiki that match it.
So I kept the english one.

@cezaraugusto cezaraugusto added the needs review A pull request ready to be reviewed label Feb 9, 2019
halian-vilela
halian-vilela requested changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent translation! Congrats.

I've suggested just some minor changes.

halian-vilela and others added 9 commits February 9, 2019 11:34
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
7d5c6da 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
82eee09 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
fae9e80 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
bd08f71 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
da58ae7 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
00dabd3 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
cff2ace 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
50894cf 
Co-Authored-By: ifdiego <[email protected]>
@halian-vilela @ifdiego
Update content/docs/components-and-props.md
7ee9397 
Co-Authored-By: ifdiego <[email protected]>
@ifdiego
Copy link
Contributor Author

ifdiego commented Feb 9, 2019

Thanks.

I've just committed the changes.

cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@cezaraugusto
Copy link
Member

@halian-vilela could you please check again?

glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ifdiego
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 merged commit 4094e00 into reactjs:master Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 10, 2019
@fjoshuajr fjoshuajr added the 🌐 translated Translation is completed for this page label Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halian-vilela halian-vilela halian-vilela requested changes

@glaucia86 glaucia86 glaucia86 approved these changes

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ifdiego @cezaraugusto @halian-vilela @glaucia86 @fjoshuajr