Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Shallow renderer #32

Merged
merged 3 commits into from
Feb 10, 2019
Merged

Translate Shallow renderer #32

merged 3 commits into from
Feb 10, 2019

Conversation

henriquejensen
Copy link
Contributor

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @henriquejensen, left some comments

@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@henriquejensen
Copy link
Contributor Author

Hey @cezaraugusto thanks for the feedback, I did the changes

cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
tibuurcio
tibuurcio reviewed Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@tibuurcio tibuurcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions basically about the use of afirmar to translate assert. Please tell me what you think about, completely open to discussion!

Thank you for taking the time 👍

glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquejensen
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 merged commit 325762f into reactjs:master Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 10, 2019
@fjoshuajr fjoshuajr added the 🌐 translated Translation is completed for this page label Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike left review comments

@tibuurcio tibuurcio tibuurcio left review comments

@glaucia86 glaucia86 glaucia86 approved these changes

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@henriquejensen @glaucia86 @jhonmike @cezaraugusto @tibuurcio @fjoshuajr