Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional Rendering translation #51

Merged
merged 14 commits into from
Feb 12, 2019
Merged

Conditional Rendering translation #51

merged 14 commits into from
Feb 12, 2019

Conversation

nsouzaco
Copy link
Contributor

@nsouzaco nsouzaco commented Feb 9, 2019

No description provided.

@nsouzaco nsouzaco changed the title translation first version Conditional Rendering translation Feb 9, 2019
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
Apply suggestions from code review
6427142 
fix typos, accents and links

Co-Authored-By: cstpk <[email protected]>
fjoshuajr
fjoshuajr requested changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@glaucia86
Copy link
Member

@cstpk

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@nsouzaco
Copy link
Contributor Author

@cstpk

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

Oi @glaucia86 , conclui as mudancas mas nao estou conseguindo alterar a label.

fjoshuajr
fjoshuajr previously approved these changes Feb 11, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@cstpk Somente os membros podem alterar a label.

@fjoshuajr fjoshuajr added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 11, 2019
WendellAdriel
WendellAdriel requested changes Feb 11, 2019
View reviewed changes
@WendellAdriel
Copy link
Member

Apenas algumas pequenas alterações.

@glaucia86
Copy link
Member

@cstpk faz as alterações que o @WendellAdriel propôs aqui e nos sinalize ;)

@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 12, 2019
@nsouzaco
Copy link
Contributor Author

concluido!

@fjoshuajr fjoshuajr added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
WendellAdriel
WendellAdriel approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@WendellAdriel WendellAdriel merged commit 256a879 into reactjs:master Feb 12, 2019
@WendellAdriel
Copy link
Member

Merge feito!!!
Muito obrigado pela contribuição @cstpk!!! 😉

@WendellAdriel WendellAdriel added 🌐 translated Translation is completed for this page and removed feedback addressed labels Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 left review comments

@jhonmike jhonmike jhonmike left review comments

@WendellAdriel WendellAdriel WendellAdriel approved these changes

@fjoshuajr fjoshuajr fjoshuajr left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nsouzaco @glaucia86 @WendellAdriel @jhonmike @fjoshuajr