Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Design Principles #60

Merged
merged 6 commits into from
Feb 18, 2019
Merged

Translate Design Principles #60

merged 6 commits into from
Feb 18, 2019

Conversation

moiseshilario
Copy link
Contributor

This PR references issue #1 translating the Design Principle doc

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
converge
converge suggested changes Feb 10, 2019
View reviewed changes
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@glaucia86 glaucia86 added needs +1 Needs another approval before merging needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed needs +1 Needs another approval before merging labels Feb 10, 2019
@moiseshilario
Copy link
Contributor Author

moiseshilario commented Feb 11, 2019 •
edited
Loading

@glaucia86 @converge Obrigado pelas sugestões e correções, a maioria delas foram aplicadas e o PR foi atualizado. Repondi alguns dos comentários, pois precisamos entrar em acordo com alguns termos. Fora isso, tudo certo para um Review de novo.

@eduardomoroni eduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
@cezaraugusto cezaraugusto self-assigned this Feb 14, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario

LGTM 👍
Muito obrigada pela sua contribuição!

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario

LGTM 👍

Muito obrigada pela sua contribuição. :)

cc: @fjoshuajr @cezaraugusto @eduardomoroni só aprovar. Mais do que revisado.

@halian-vilela halian-vilela self-requested a review February 15, 2019 00:04
halian-vilela
halian-vilela requested changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blz! Solicitei algumas pequenas modificações de detalhes que melhorariam a compreensão.

Por favor, revise e faça suas consideraçõe, se necessário, e logo sua contribuição será aprovada!

Obrigado!

@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 15, 2019
@moiseshilario moiseshilario dismissed stale reviews from glaucia86 via 6be8e95 February 18, 2019 14:01
@moiseshilario
Copy link
Contributor Author

@halian-vilela Muito obrigado pelas correções! PR foi corrigido e atualizado. Esperando review e aprovação.

@halian-vilela halian-vilela merged commit 94c077a into reactjs:master Feb 18, 2019
@halian-vilela halian-vilela added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 18, 2019
@tesseralis tesseralis mentioned this pull request Feb 18, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@converge converge converge requested changes

@halian-vilela halian-vilela halian-vilela approved these changes

@glaucia86 glaucia86 glaucia86 left review comments

Assignees

@halian-vilela halian-vilela

@glaucia86 glaucia86

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@moiseshilario @converge @halian-vilela @glaucia86 @eduardomoroni @cezaraugusto @fjoshuajr