Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Lifting State Up #96

Merged
merged 6 commits into from
Feb 16, 2019
Merged

Translate Lifting State Up #96

merged 6 commits into from
Feb 16, 2019

Conversation

gustavobini
Copy link
Contributor

#1

@eduardomoroni eduardomoroni added the needs +1 Needs another approval before merging label Feb 14, 2019
eduardomoroni
eduardomoroni previously approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show de bola @gustavobini, fiz algumas sugestões mas podemos mergear do jeitinho que está.

Valeu

@eduardomoroni eduardomoroni added the needs author response Changes requested needing author's input label Feb 14, 2019
@eduardomoroni eduardomoroni self-assigned this Feb 14, 2019
@jhonmike
Copy link
Member

jhonmike commented Feb 14, 2019 •
edited
Loading

acho que não precisa enviar o package-lock.json na diff do seu PR.
Seria legal traduzir também o titulo da pagina.

@tesseralis tesseralis mentioned this pull request Feb 14, 2019
Closed
90 tasks
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobini faça as alterações solicitadas por mim e pelo @eduardomoroni que logo em seguida estaremos aprovando a sua contribuição.

Muito obrigada! :)

@glaucia86 glaucia86 dismissed their stale review February 14, 2019 22:53

precisa realizar algumas alterações.

glaucia86
glaucia86 requested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobini faça as alterações solicitadas por mim e pelo @eduardomoroni que logo em seguida estaremos aprovando a sua contribuição.

Muito obrigada! :)

@gustavobini
Apply suggestions from code review
e29c5c7 
Translating codepen links

Co-Authored-By: gustavobini <[email protected]>
@gustavobini gustavobini dismissed stale reviews from eduardomoroni via e29c5c7 February 14, 2019 22:59
@gustavobini
Copy link
Contributor Author

@gustavobini faça as alterações solicitadas por mim e pelo @eduardomoroni que logo em seguida estaremos aprovando a sua contribuição.

Muito obrigada! :)

Prontinho!

@eduardomoroni eduardomoroni added feedback addressed and removed needs +1 Needs another approval before merging needs author response Changes requested needing author's input labels Feb 16, 2019
glaucia86
glaucia86 approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobini

LGTM 👍

Agradecemos pela sua excelente contribuição! :)

@glaucia86 glaucia86 merged commit b890fbb into reactjs:master Feb 16, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed feedback addressed labels Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike left review comments

@eduardomoroni eduardomoroni eduardomoroni approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees

@eduardomoroni eduardomoroni

@glaucia86 glaucia86

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gustavobini @jhonmike @eduardomoroni @glaucia86 @cezaraugusto