remove assertions on data-reactroot

see facebook/react#10971
reactjs · Jul 20, 2023 · ba1e257 · ba1e257
1 parent 098f2df
commit ba1e257
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/test/react/server_rendering/bundle_renderer_test.rb b/test/react/server_rendering/bundle_renderer_test.rb
@@ -33,7 +33,6 @@ class BundleRendererTest < ActiveSupport::TestCase
     test '#render returns HTML' do
       result = @renderer.render('Todo', { todo: 'write tests' }, nil)
       assert_match(/<li.*write tests<\/li>/, result)
-      assert_match(/data-reactroot/, result)
     end
 
     test '#render accepts strings' do
@@ -44,7 +43,6 @@ class BundleRendererTest < ActiveSupport::TestCase
     test '#render accepts :static pre-render option' do
       result = @renderer.render('Todo', { todo: 'write more tests' }, :static)
       assert_match(/<li>write more tests<\/li>/, result)
-      assert_no_match(/data-reactroot/, result)
     end
 
     test '#render replays console messages' do

diff --git a/test/react/server_rendering/exec_js_renderer_test.rb b/test/react/server_rendering/exec_js_renderer_test.rb
@@ -23,14 +23,13 @@ class ExecJSRendererTest < ActiveSupport::TestCase
 
   test '#render returns HTML' do
     result = @renderer.render('Todo', { todo: 'write tests' }.to_json, {})
+    p result
     assert_match(/<li.*write tests<\/li>/, result)
-    assert_match(/data-reactroot/, result)
   end
 
   test '#render accepts render_function:' do
     result = @renderer.render('Todo', { todo: 'write more tests' }.to_json, render_function: 'renderToStaticMarkup')
     assert_match(/<li>write more tests<\/li>/, result)
-    assert_no_match(/data-reactroot/, result)
   end
 
   test '#before_render is called before #after_render' do