Make generator es6 and ts usable at same time

[ippachi]

Summary

Thank you for great integration rails and react. I use react-rails recently and I notice that I can't use --ts and --es6 same time. What about making these two available at the same time?

Other Information

This is actual generated file

rails g react:component HelloWorld greeting:string --ts --es6

import * as React from "react"

interface IHelloWorldProps {
  greeting: string;
}

const HelloWorld = (props: IHelloWorldProps) => {
  return (
    <React.Fragment>
      Greeting: {props.greeting}
    </React.Fragment>
  )
}

export default HelloWorld

Pull Request checklist

• Add/update test to cover these changes
• Update documentation
• Update CHANGELOG file

[ahangarha]

I think It would be good to use indentation here.

[ippachi]

@ahangarha
Do you mean this?

interface I<%= component_name %>Props {
  <% if attributes.size > 0 -%>
  <% attributes.each do | attribute | -%>
  <% if attribute[:union] -%>
  <%= attribute[:name].camelize(:lower) %>: <%= attribute[:name].titleize %>;
  <% else -%>
  <%= attribute[:name].camelize(:lower) %>: <%= attribute[:type] %>;
  <% end -%>
  <% end -%>
  <% end -%>
}

But All <% in template have no indentation.

[ahangarha]

I can say the indentations there are not ideal. Better to make a little improvement in each PR.

[ippachi]

@ahangarha
OK. I have tried fixing indentation.

[ahangarha]

I think it can still be improved, but also the issue is beyond the changes in this particular PR.

So, I don't want to block the PR for this specific reason.

@Judahmeek If there is no other issue except this one, I think we are good to move forward.

[Judahmeek]

@ippachi Please resolve @ahangarha's comment & also please rebase to address the Changelog conflict.

[justin808]

Thank you @ippachi for your contribution.