Tune OnAssemblyException.toString for better traceback rendering #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominikbrandon Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
|
@dominikbrandon Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@dominikbrandon Thank you for signing the Contributor License Agreement! |
simonbasle
suggested changes
Oct 15, 2021
reactor-core/src/main/java/reactor/core/publisher/FluxOnAssembly.java
Outdated
Show resolved
Hide resolved
simonbasle
suggested changes
Oct 15, 2021
reactor-core/src/test/java/reactor/core/publisher/FluxOnAssemblyTest.java
Outdated
Show resolved
Hide resolved
|
@dominikbrandon I like the effort that you put into the PR, including the reference guide change 👍 We don't normall participate in Hacktoberfest, but I might consider temporarily creating the required label for this PR. |
simonbasle
approved these changes
Oct 18, 2021
simonbasle
added
area/devexp
simonbasle
changed the title
8 tasks
This was referenced Nov 12, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following issue: #2786.
If you have any suggestions please go ahead, I'll be happy to fix that.
If you liked my work, I'd be glad if you could mark this PR as
hacktoberfest-accepted. Thanks!