Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] Bump OpCode to ASM9 for compatibility with newer JDKs #2825

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

simonbasle
Copy link
Contributor

This is so ByteBuddy doesn't trip on eg. records, even though the
reactor-tool agent visitors don't act on these for now.

Fixes #2821.

This is so ByteBuddy doesn't trip on eg. records, even though the
reactor-tool agent visitors don't act on these for now.

Fixes #2821.
@simonbasle simonbasle requested a review from a team as a code owner October 22, 2021 08:11
@simonbasle simonbasle added this to the 3.4.12 milestone Oct 22, 2021
@simonbasle simonbasle added area/java9 This belongs to the java9 compatibility theme type/bug A general bug type/chores A task not related to code (build, formatting, process, ...) labels Oct 22, 2021
@simonbasle simonbasle self-assigned this Oct 22, 2021
@simonbasle simonbasle requested a review from a team October 22, 2021 08:11
@simonbasle simonbasle changed the title Bump ASM OpCode to ASM9 for compatibility with newer JDKs [agent] Bump ASM OpCode to ASM9 for compatibility with newer JDKs Oct 22, 2021
Copy link
Contributor

@OlegDokuka OlegDokuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonbasle simonbasle changed the title [agent] Bump ASM OpCode to ASM9 for compatibility with newer JDKs [agent] Bump OpCode to ASM9 for compatibility with newer JDKs Nov 2, 2021
@simonbasle simonbasle merged commit 32e6acb into 3.3.x Nov 2, 2021
@simonbasle simonbasle deleted the 2821-byteBuddyASM9 branch November 2, 2021 08:52
@reactorbot
Copy link

@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/java9 This belongs to the java9 compatibility theme type/bug A general bug type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants