Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gradle-build-action for invoking Gradle on CI #2828

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

bigdaz
Copy link
Contributor

@bigdaz bigdaz commented Nov 1, 2021

The gradle/gradle-build-action replaces eskatos/gradle-command-action, and v2 brings a number of improvements around caching and usability.

@bigdaz bigdaz requested a review from a team as a code owner November 1, 2021 19:01
Copy link
Contributor

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the suggestion @bigdaz !
this looks good to me.

would you be willing however to re-target this PR on the 3.3.x branch? (github workflows should be the same there).

also have a single doubt on the last set of arguments (see inline comment)

.github/workflows/publish.yml Outdated Show resolved Hide resolved
@bigdaz bigdaz force-pushed the gradle-build-action branch from 91f3e43 to 2b88c9c Compare November 2, 2021 16:07
@bigdaz bigdaz changed the base branch from main to 3.3.x November 2, 2021 16:08
@bigdaz
Copy link
Contributor Author

bigdaz commented Nov 2, 2021

PR rebased on 3.3.x branch and publish.yml fixed as requested.

@bigdaz bigdaz requested a review from simonbasle November 2, 2021 16:22
@simonbasle
Copy link
Contributor

checks are still shown as "waiting" despite at least one restarted and passing. I'll just close and reopen this PR to force a trigger of checks again.

@simonbasle simonbasle closed this Nov 4, 2021
@simonbasle simonbasle reopened this Nov 4, 2021
@simonbasle simonbasle added the type/chores A task not related to code (build, formatting, process, ...) label Nov 4, 2021
@simonbasle simonbasle added this to the 3.3.22.RELEASE milestone Nov 4, 2021
@simonbasle simonbasle merged commit 8177341 into reactor:3.3.x Nov 4, 2021
@reactorbot
Copy link

@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@simonbasle
Copy link
Contributor

simonbasle commented Nov 4, 2021

wait, these are not only replacing the eskatos usage, but also the run usage. we decided that for publishing artifacts we'd avoid 3rd party gh actions as much as possible. I'll revert that part on 3.3.x before forward merging the CI.yml change only. (edit: left also the test step to use gradle's action).

simonbasle added a commit that referenced this pull request Nov 4, 2021
simonbasle added a commit that referenced this pull request Nov 4, 2021
Adapted the check steps to have slowerCheck job also use the gradle
official action (since it doesn't have access to secrets either).
@bigdaz
Copy link
Contributor Author

bigdaz commented Nov 4, 2021

Thanks for merging, and yes I took the liberty of updating all Gradle invocations. Apologies if that wasn't desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants