-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gradle-build-action for invoking Gradle on CI #2828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the suggestion @bigdaz !
this looks good to me.
would you be willing however to re-target this PR on the 3.3.x
branch? (github workflows should be the same there).
also have a single doubt on the last set of arguments (see inline comment)
91f3e43
to
2b88c9c
Compare
PR rebased on |
checks are still shown as "waiting" despite at least one restarted and passing. I'll just close and reopen this PR to force a trigger of checks again. |
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
wait, these are not only replacing the |
Thanks for merging, and yes I took the liberty of updating all Gradle invocations. Apologies if that wasn't desired. |
The
gradle/gradle-build-action
replaceseskatos/gradle-command-action
, andv2
brings a number of improvements around caching and usability.