Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for obtaining request ID #1530

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Add API for obtaining request ID #1530

merged 1 commit into from
Mar 4, 2021

Conversation

violetagg
Copy link
Member

Request ID is a combination of the id of the underlying connection
and the serial number of the request received on that connection.

Request ID is a combination of the id of the underlying connection
and the serial number of the request received on that connection.
@violetagg violetagg added this to the 1.0.5 milestone Mar 4, 2021
Copy link
Contributor

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to touch a little bit more than the new API (ReactorNettyLoggingHandler), so I'd mention that in the commit body, but otherwise looks good.

@violetagg violetagg merged commit af2d17f into master Mar 4, 2021
@violetagg
Copy link
Member Author

seems to touch a little bit more than the new API (ReactorNettyLoggingHandler), so I'd mention that in the commit body, but otherwise looks good.

yes true

I updated the commit. Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants