-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HttpClientWithTomcatTest
flaky test.
#2903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pderop
force-pushed
the
1.0.x-fix-tomcat-flaky-test
branch
4 times, most recently
from
September 20, 2023 08:46
3c330b3
to
ab870d0
Compare
pderop
force-pushed
the
1.0.x-fix-tomcat-flaky-test
branch
from
September 20, 2023 09:56
ab870d0
to
4ffdb9d
Compare
I think that the errors from the windows checks are not related. |
pderop
force-pushed
the
1.0.x-fix-tomcat-flaky-test
branch
6 times, most recently
from
September 21, 2023 20:55
f611bdd
to
c272232
Compare
Adapted maxSwallowSize, and PAYLOAD size. Do not configure Tomcat socket rcvbuf size anymore. Reduce HttpClient sndbuf size. 400 Bad Request is not sent with chunked encoding. temporary testing temporary testing
pderop
force-pushed
the
1.0.x-fix-tomcat-flaky-test
branch
from
September 22, 2023 08:12
502ec7a
to
e85df38
Compare
violetagg
requested changes
Sep 22, 2023
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientWithTomcatTest.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientWithTomcatTest.java
Outdated
Show resolved
Hide resolved
just applied the suggested changes. |
violetagg
approved these changes
Sep 22, 2023
pderop
added a commit
that referenced
this pull request
Sep 22, 2023
pderop
added a commit
that referenced
this pull request
Sep 22, 2023
@violetagg , thanks for your review. |
pderop
added a commit
to pderop/reactor-netty
that referenced
this pull request
Sep 25, 2023
pderop
added a commit
that referenced
this pull request
Sep 25, 2023
Fix cross-site scripting (XSS) vulnerability github security alert in the TomcatServer class. See https://github.com/reactor/reactor-netty/security/code-scanning/9
violetagg
changed the title
Fix HttpClientWithTomcatTest flaky test.
Fix Sep 28, 2023
HttpClientWithTomcatTest
flaky test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new attempt to fix the flaky test from HttpClientWithTomcatTest.testIssue2825, which was still sometimes getting some Premature Close Exception.
To summarize:
HttpClient.send(Mono)
is used #2864 significantly reduces the probability to get premature close exceptions when Tomcat sends an early final response 400 bad request while the client is still writing a large request body. Did a benchmark using a real network, it works well; no premature close exceptions.Did the following fixes:
PayloadSizeServlet
which was not counting correctly the number of bytes received.HttpClient.send(Mono)
is used #2864