Add request maximum timeout #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2019 10:42
|
@WyriHaximus @clue @jsor ping |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional maximum timeout for requests. The maximum timeout is measured from the start of the request (just before connecting) to the end of the response.
To allow this to be implemented in a non-BC way, I've added two methods to the
Requestclass which should be moved into the constructor in the next major version.The event loop is automatically set in the
Clientafter creating theRequestand as such the method is marked as internal.I've added documentation to the README and tests. I'm not completely sure if the tests are okay, so these should be verified.
Resolves #28.