Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new HeaderBag (modeled after Symfony) to support case-insensitive header matching. #53

Closed
wants to merge 3 commits into from

Conversation

pwhelan
Copy link

@pwhelan pwhelan commented Mar 22, 2016

Used a new HeaderBag class to support case-insensitive header name matches. This fixes a bug where ab (Apache Benchmark) simply hangs.

@WyriHaximus WyriHaximus mentioned this pull request Mar 22, 2016
8 tasks
@clue
Copy link
Member

clue commented Mar 22, 2016

support case-insensitive header name matches

Thanks for your effort @pwhelan! I agree that this a bug that needs fixing 👍

However, the current implementation contains a BC break and I see little we could do about this on this level. As an alternative, I would vote for waiting for #41 to remove most (all?) of the assumptions on headers.

FWIW: Proper header parsing will probably be resolved once we look into PSR-7 support (#28).

@clue
Copy link
Member

clue commented Sep 13, 2016

Afaict this has been filed to fix the previously broken master branch. Now that #59 is in, is this still relevant?

@pwhelan
Copy link
Author

pwhelan commented Oct 4, 2016

Afaict this has been filed to fix the previously broken master branch. Now that #59 is in, is this still relevant?

I'll have to test that to be sure. This bug was kept open pending the merge of #41 (at least on my end).

I'll test this soon to be sure. This was meant primarily to fix problems with ab (Apache Benchmark) and other http clients (curl, possibly jmeter as well) which use 'Content-length' instead of 'Content-Length'. This happens enough in the wild that it has to be supported.

If #59 does fix this then it can be closed.

@clue
Copy link
Member

clue commented Feb 10, 2017

Thanks for filing this PR, I can assure you we're working hard on this 👍

This PR currently targets an unstable development feature that is no longer part of the master branch, so I've just filed #105 to keep track of the underlying feature request here. Please bear with us, we'll keep this ticket updated 👍

See also #51, which I'm currently looking into 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants