Use pcov for code coverage

reactphp · Feb 23, 2020 · 8c9bfae · 8c9bfae
1 parent e7c043f
commit 8c9bfae
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -15,6 +15,8 @@ matrix:
     - php: nightly
 
 install:
+  - phpenv config-rm xdebug.ini
+  - pecl install pcov
   - composer install
 
 script:

diff --git a/tests/DeferredTest.php b/tests/DeferredTest.php
@@ -23,9 +23,9 @@ public function getPromiseTestAdapter(callable $canceller = null)
     /** @test */
     public function shouldRejectWithoutCreatingGarbageCyclesIfCancellerRejectsWithException()
     {
-        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
-            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
-        }
+//        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+//            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+//        }
 
         gc_collect_cycles();
         $deferred = new Deferred(function ($resolve, $reject) {
@@ -40,9 +40,9 @@ public function shouldRejectWithoutCreatingGarbageCyclesIfCancellerRejectsWithEx
     /** @test */
     public function shouldRejectWithoutCreatingGarbageCyclesIfParentCancellerRejectsWithException()
     {
-        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
-            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
-        }
+//        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+//            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+//        }
 
         gc_collect_cycles();
         $deferred = new Deferred(function ($resolve, $reject) {
@@ -57,9 +57,9 @@ public function shouldRejectWithoutCreatingGarbageCyclesIfParentCancellerRejects
     /** @test */
     public function shouldRejectWithoutCreatingGarbageCyclesIfCancellerHoldsReferenceAndExplicitlyRejectWithException()
     {
-        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
-            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
-        }
+//        if ($this->getTestResultObject()->getCollectCodeCoverageInformation() === true) {
+//            $this->markTestSkipped('This test has memory leaks when code coverage is collected');
+//        }
 
         gc_collect_cycles();
         $deferred = new Deferred(function () use (&$deferred) { });