Remove named constructor from CompositeException

reactphp · Sep 21, 2017 · df0976e · df0976e
1 parent 07b7afd
commit df0976e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 13 deletions.
diff --git a/src/Exception/CompositeException.php b/src/Exception/CompositeException.php
@@ -27,12 +27,4 @@ public function getExceptions()
     {
         return $this->exceptions;
     }
-
-    public static function tooManyPromisesRejected(array $reasons)
-    {
-        return new self(
-            $reasons,
-            'Too many promises rejected.'
-        );
-    }
 }
diff --git a/src/functions.php b/src/functions.php
@@ -115,7 +115,10 @@ function some(array $promisesOrValues, $howMany)
 
                 if (0 === --$toReject) {
                     $reject(
-                        CompositeException::tooManyPromisesRejected($reasons)
+                        new CompositeException(
+                            $reasons,
+                            'Too many promises rejected.'
+                        )
                     );
                 }
             };

diff --git a/tests/FunctionAnyTest.php b/tests/FunctionAnyTest.php
@@ -58,8 +58,9 @@ public function shouldRejectWithAllRejectedInputValuesIfAllInputsAreRejected()
         $exception2 = new \Exception();
         $exception3 = new \Exception();
 
-        $compositeException = CompositeException::tooManyPromisesRejected(
-            [0 => $exception1, 1 => $exception2, 2 => $exception3]
+        $compositeException = new CompositeException(
+            [0 => $exception1, 1 => $exception2, 2 => $exception3],
+            'Too many promises rejected.'
         );
 
         $mock = $this->createCallableMock();

diff --git a/tests/FunctionSomeTest.php b/tests/FunctionSomeTest.php
@@ -101,8 +101,9 @@ public function shouldRejectIfAnyInputPromiseRejectsBeforeDesiredNumberOfInputsA
         $exception2 = new \Exception();
         $exception3 = new \Exception();
 
-        $compositeException = CompositeException::tooManyPromisesRejected(
-            [1 => $exception2, 2 => $exception3]
+        $compositeException = new CompositeException(
+            [1 => $exception2, 2 => $exception3],
+            'Too many promises rejected.'
         );
 
         $mock = $this->createCallableMock();