-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/xml memleak fix #190
base: develop
Are you sure you want to change the base?
Conversation
Reviewed. Looks fine to me, but I am not super-familiar with the logic that tracks XML node allocation, shared pointer, etc. So I guess the best way to test this PR is to open-close-open a number of EPUBs on iOS, Android and / or OSX, and profile / trace memory state. Unfortunately I don't think it is safe to assume that "if it works on platform-A, it should work on platform-B" (because of XML lib + WebView discrepancies?). |
Also https://github.com/readium/readium-sdk/tree/feature/feature_revised_launcher/Platform/Windows |
I commented here about separating the Windows-specific code changes (i.e. the memory leak fix should work in all platforms): |
This is part of the work on Windows. As our support for Windows is up in the air, not sure what we will do here. |
PR for XML weak_ptr memory leak fix
please see the feature/xml_memleak_fix commit history
Note: it is compiled and tested on Windows&VS2013
I'm not sure it would compile ok for the other platforms, so please fix if required
Thanks