Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for array out of bounds #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes for array out of bounds #29

wants to merge 2 commits into from

Conversation

sanbrother
Copy link

For some special books that has no NCX, but navigation not empty, bad access exception raises.
The special books' navigation contains pure text rather than links.

@sanbrother
Copy link
Author

Some books stores *.opf in root folder, relative path should not be prefixed by '/'.

@rkwright
Copy link
Contributor

Although this is very old, leaving it open as a reminder to review the PR in case it is still relevant.

@danielweck
Copy link
Member

I would advise against changing the BasePath to "" (empty string) instead of "/". I am well aware of this APi annoyance / inconsistency, but we cannot risk breaking existing reading system implementations that have depended on this behaviour for a long time (AbsolutePath when EPUB files are at root of archive). I implemented workarounds in Media Overlays some time ago, and more recently in obfuscated fonts.
I will take a look at the other code changes, but package.cpp requires great caution.

@rkwright
Copy link
Contributor

Ok, thanks

Sent with my thumbs

On Oct 24, 2014, at 3:39 PM, danielweck [email protected] wrote:

I would advise against changing the BasePath to "" (empty string) instead of "/". I am well aware of this APi annoyance / inconsistency, but we cannot risk breaking existing reading system implementations that have depended on this behaviour for a long time (AbsolutePath when EPUB files are at root of archive). I implemented workarounds in Media Overlays some time ago, and more recently in obfuscated fonts.
I will take a look at the other code changes, but package.cpp requires great caution.


Reply to this email directly or view it on GitHub.

@rkwright rkwright removed bug labels May 13, 2016
@rkwright rkwright removed this from the m1.1 milestone May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants