-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[![PR App][icn]][demo] | Ref RM-10929 :-------------------:|:----------: ## 🧰 Changes Fixes rendering some captions. It's super unclear to me why sometimes the image saves the caption as children and sometimes as a prop. But it wasn't rendering the children! ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
- Loading branch information
1 parent
90bf6e6
commit 0db3627
Showing
6 changed files
with
40 additions
and
1 deletion.
There are no files selected for viewing
Binary file added
BIN
+99.5 KB
...l-regression-tests-rdmd-syntax-renders-image-tests-without-surprises-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.57 KB
(79%)
...-visual-regression-tests-rdmd-syntax-renders-lists-without-surprises-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
We're excited you're here! :blue_heart: | ||
|
||
<Image src="https://owlbertsio-resized.s3.amazonaws.com/Blocks.psd.full.png"> | ||
Owlbert! | ||
</Image> | ||
|
||
<Table align={["left","left","left"]}> | ||
<thead> | ||
<tr> | ||
<th style={{ textAlign: "left" }} /> | ||
|
||
<th style={{ textAlign: "left" }} /> | ||
|
||
<th style={{ textAlign: "left" }} /> | ||
</tr> | ||
</thead> | ||
|
||
<tbody> | ||
<tr> | ||
<td style={{ textAlign: "left" }} /> | ||
|
||
<td style={{ textAlign: "left" }} /> | ||
|
||
<td style={{ textAlign: "left" }} /> | ||
</tr> | ||
|
||
<tr> | ||
<td style={{ textAlign: "left" }} /> | ||
|
||
<td style={{ textAlign: "left" }} /> | ||
|
||
<td style={{ textAlign: "left" }} /> | ||
</tr> | ||
</tbody> | ||
</Table> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters