Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mermaid diagrams #994

Merged
merged 9 commits into from
Oct 22, 2024
Merged

feat: mermaid diagrams #994

merged 9 commits into from
Oct 22, 2024

Conversation

trishaprile
Copy link
Member

@trishaprile trishaprile commented Oct 14, 2024

PR App Fix RM-10840

🧰 Changes

  • Support Mermaid as a code block language
  • If it's a single diagram, render without a code block
  • If there's multiple tabs, render within a code block
image image

🧬 QA & Testing

@trishaprile trishaprile marked this pull request as ready for review October 21, 2024 16:32
Copy link
Collaborator

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yea.

@trishaprile
Copy link
Member Author

@kellyjosephprice are any of theses failed tests valid

@kellyjosephprice
Copy link
Collaborator

@kellyjosephprice are any of theses failed tests valid

No, but lets hold off an merging till we get the build fixed.

@kellyjosephprice
Copy link
Collaborator

@trishaprile would you try merging next in now?

@trishaprile trishaprile merged commit af6e306 into next Oct 22, 2024
12 of 13 checks passed
@trishaprile trishaprile deleted the feat/mermaid-diagrams branch October 22, 2024 18:29
rafegoldberg pushed a commit that referenced this pull request Oct 22, 2024
## Version 7.7.0

### ✨ New & Improved

* mermaid diagrams ([#994](#994)) ([af6e306](af6e306))

### 🛠 Fixes & Updates

* missing close icon ([#995](#995)) ([7012fe3](7012fe3))
* replace node-sass ([#997](#997)) ([3637314](3637314))
* rollback html fixes ([#996](#996)) ([8c96e92](8c96e92))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants