Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace node-sass #997

Merged
merged 3 commits into from
Oct 21, 2024
Merged

chore: replace node-sass #997

merged 3 commits into from
Oct 21, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

PR App

🧰 Changes

Replace node-sass with dart-sass (sass).

node-sass started failing to build on the github action runners. Eek! I guess it's time to chuck it. 👋

🧬 QA & Testing

@kellyjosephprice kellyjosephprice marked this pull request as ready for review October 17, 2024 20:21
@kellyjosephprice
Copy link
Collaborator Author

@rafegoldberg the visual snapshot tests pass? Is there anything else I should be looking for?

Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If visual tests are passing this is probably all good!

@kellyjosephprice kellyjosephprice merged commit 3637314 into next Oct 21, 2024
13 checks passed
@kellyjosephprice kellyjosephprice deleted the chore/update-node-sass branch October 21, 2024 22:34
rafegoldberg pushed a commit that referenced this pull request Oct 22, 2024
## Version 7.7.0

### ✨ New & Improved

* mermaid diagrams ([#994](#994)) ([af6e306](af6e306))

### 🛠 Fixes & Updates

* missing close icon ([#995](#995)) ([7012fe3](7012fe3))
* replace node-sass ([#997](#997)) ([3637314](3637314))
* rollback html fixes ([#996](#996)) ([8c96e92](8c96e92))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants