Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate export #1009

Merged
merged 3 commits into from
Nov 1, 2024
Merged

feat: migrate export #1009

merged 3 commits into from
Nov 1, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Oct 30, 2024

PR App Ref RM-11191

🧰 Changes

Adds a migrate export and moves a replaceAll into this repo.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to feat/compat-parser October 30, 2024 17:58
@kellyjosephprice kellyjosephprice marked this pull request as ready for review October 30, 2024 20:06
Base automatically changed from feat/compat-parser to next October 30, 2024 21:20
Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise this looks good to me!

lib/index.ts Show resolved Hide resolved
import mdastV6 from './mdastV6';

const migrate = (doc: string): string => {
return mdx(mdastV6(doc)).replaceAll(/ /g, ' ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this using the newly integrated compat processor behind the scenes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup yup yup. mdastV6 is the same thing, and this migrate export is just wrapping it all into one.

@kellyjosephprice kellyjosephprice merged commit a0433fe into next Nov 1, 2024
13 checks passed
@kellyjosephprice kellyjosephprice deleted the feat/migrate-export branch November 1, 2024 20:54
rafegoldberg pushed a commit that referenced this pull request Nov 1, 2024
## Version 7.9.0
### ✨ New & Improved

* migrate export ([#1009](#1009)) ([a0433fe](a0433fe))

### 🛠 Fixes & Updates

* migrate tables with html ([#1005](#1005)) ([2aa7b83](2aa7b83))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants