Correct import for ethical-ad-client #6
Comments
|
This is related to #5 and I think we need to do some work there first. |
humitos
added a commit
that referenced
this issue
Sep 4, 2023
- remove dependency - don't require UDM library changes/complexity - load the dependency only if EthicalAd is enabled for the project - protect us from blocking `readthedocs-addons.js` by AdBlocker I decided to go this way because it simplifies things a lot and also it uses the standard/supported way of using EthicaAd client. * Closes #6 * Closes #81 * Closes readthedocs/ethical-ad-client#155
humitos
added a commit
that referenced
this issue
Sep 5, 2023
- remove dependency - don't require UDM library changes/complexity - load the dependency only if EthicalAd is enabled for the project (useful for commercial 👍🏼 ) - protect us from blocking `readthedocs-addons.js` by AdBlocker I decided to go this way because it simplifies things a lot and also it uses the standard/supported way of using EthicaAd client. * Closes #6 * Closes #81 * Closes readthedocs/ethical-ad-client#155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is also an issue with the ea-client, just noting here to find a solution.
The fix for the import statement is that the ea-client package.json is wrong.
The
mainconfiguration option points to a file that doesn't exist.main: "dist/ethicalads.js"at the ethical-ad-client package configuration solves the import problems here,and
import "ethical-ad-client"worked with this change.The text was updated successfully, but these errors were encountered: