API: send project-slug= and version-slug= to the backend
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the plan discussed in readthedocs/readthedocs.org#10536 Grab the `project-slug` and `version-slug` from the `meta` tag injected by CF and send it back to the backend. If there is any addons that can be enabled in the current page that depends on the URL, it will send it also. Each Addon class should implement `requireUrlParam` to decide whether or not to send the `url=` to the backend API or not.
… humitos/send-project-version-slugs
agjohnson
approved these changes
Oct 24, 2023
humitos
added a commit
that referenced
this pull request
Oct 24, 2023
Since we are not always sending the `url=` parameter, it could happen that `addons.doc_diff` does not come in the response. This commit uses `objectPath` to be prepared for that case. Related #170
humitos
added a commit
that referenced
this pull request
Oct 24, 2023
Since we are not always sending the `url=` parameter, it could happen that `addons.doc_diff` does not come in the response. This commit uses `objectPath` to be prepared for that case. Related #170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the plan discussed in readthedocs/readthedocs.org#10536
Grab the
project-slugandversion-slugfrom themetatag injected by CF and send it back to the backend. If there is any addons that can be enabled in the current page that depends on the URL, it will send it also.Each Addon class should implement
requireUrlParamto decide whether or not to send theurl=to the backend API or not.API changes in: readthedocs/readthedocs.org#10823