Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: allow disable latest and/or non-stable #414

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 29, 2024

@humitos humitos requested a review from a team as a code owner October 29, 2024 14:50
@humitos humitos requested a review from agjohnson October 29, 2024 14:50
humitos added a commit to readthedocs/ext-theme that referenced this pull request Oct 29, 2024
Instead of showing one checkbox to enable "Show notification on latest and
non-stable versions" we have two checkboxes now:

- "Show notification on latest version"
- "Show notification on non-stable versions"

Requires readthedocs/addons#414
Requires readthedocs/readthedocs.org#11718
@humitos
Copy link
Member Author

humitos commented Oct 31, 2024

Backend and frontend PRs are already approved. This is only one missing for review to be able to merge them all.

humitos added a commit to readthedocs/ext-theme that referenced this pull request Nov 4, 2024
Instead of showing one checkbox to enable "Show notification on latest
and non-stable versions" we have two checkboxes now:

- "Show notification on latest version"
- "Show notification on non-stable versions"



![Screenshot_2024-10-29_15-52-36](https://github.com/user-attachments/assets/60a35c09-cf9d-4429-af53-41515f00ecac)

Requires readthedocs/addons#414
Requires readthedocs/readthedocs.org#11718
@humitos humitos merged commit 81c058c into main Nov 4, 2024
4 checks passed
@humitos humitos deleted the humitos/notifications-split-latest-non-stable branch November 4, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification: allow to disable latest and/or non-stable warning
2 participants