Server changes needed for view time #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: these changes include a migration that adds a column to the Offer table. This should be run with extreme care in prod.
ericholscher
approved these changes
Jul 20, 2021
Co-authored-by: Eric Holscher <[email protected]>
ericholscher
approved these changes
Aug 11, 2021
| @@ -722,6 +734,35 @@ def get_response(self, request, advertisement, publisher): | |||
| return HttpResponseRedirect(url) | |||
|
|
|||
|
|
|||
| class AdViewTimeProxyView(AdViewProxyView): | |||
There was a problem hiding this comment.
What are we using from the AdViewProxyView that requires subclassing? Seems we're removing most of the logic?
There was a problem hiding this comment.
Mostly just getting the relevant offer, publisher, and ad.
We were at one point but I don't believe we are currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the server changes needed to account for view time sent from the client in readthedocs/ethical-ad-client#76.
Note: these changes include a migration that adds a column to the Offer table. This should be run with extreme care in prod.
Fixes #359 from a data capture perspective but the data still needs to be put into reports and such. We should probably collect data for a while before doing that.