Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder: remove PDF support for Sphinx<=1.6.1 #9886

Closed
humitos opened this issue Jan 11, 2023 · 0 comments · Fixed by #9967
Closed

Builder: remove PDF support for Sphinx<=1.6.1 #9886

humitos opened this issue Jan 11, 2023 · 0 comments · Fixed by #9967
Labels
Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Jan 11, 2023

We are running a command on each build to detect if sphinx>=1.6.1 and decide whether or not use latexmk.

readthedocs.org/readthedocs/doc_builder/backends/sphinx.py

Lines 310 to 311 in 84a149a

If the version of ``sphinx`` is greater or equal to 1.6.1 it returns
``True`` and ``False`` otherwise.

I quickly check our Metabase query and I found that we have 0 projects using such an older versions, https://ethicalads.metabaseapp.com/question/250-projects-using-sphinx-timeserie, so I'm happy to remove this code and always use latexmk.

This will simplify the code and remove the execution of one extra command on all the builds.
@humitos humitos added the Needed: design decision A core team decision is required label Jan 11, 2023
@humitos humitos mentioned this issue Jan 19, 2023
Closed
humitos added a commit that referenced this issue Jan 31, 2023
@humitos
Build: remove pdflatex support
134730d 
`pdflatex` is only called for project using `Sphinx<=1.6.1` --which we haven't
had anyone in the last 6 months.

Closes #9886
@humitos humitos mentioned this issue Jan 31, 2023
Merged
humitos added a commit that referenced this issue Feb 7, 2023
@humitos
Build: remove pdflatex support (#9967)
f4215c5 
* Build: remove `pdflatex` support

`pdflatex` is only called for project using `Sphinx<=1.6.1` --which we haven't
had anyone in the last 6 months.

Closes #9886

* Docs: remove mentions to `pdflatex`

* Test: remove `import sys` command from build commands

* Test: match `cat` on mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build: remove pdflatex support readthedocs/readthedocs.org
1 participant
@humitos