Build: check if the output directory is a directory #9939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It checks for `_readthedocs/<format>` output directory to be a directory. If it's not a directory, it silently skip that format for now. This behavior will change once we move out `store_build_artifacts` from `on_success` and we can communicate errors easily to the user. Related #9931
| version=self.data.version.slug, | ||
| type_=artifact_type, | ||
| ) | ||
| if os.path.isdir(artifact_directory): |
There was a problem hiding this comment.
Don't we want this to be a directory? Won't we basically be checking if _readthedocs/pdf is a directory, which we want? I think we want to check it's not a directory, and if it has multiple files in it, if it is?
There was a problem hiding this comment.
Yes. You already found that I've already solve this problem in the following PR.
|
I closed this PR. We are continuing the conversation in #9941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It checks for
_readthedocs/<format>output directory to be a directory. If it's not a directory, it silently skip that format for now. This behavior will change once we move outstore_build_artifactsfromon_successand we can communicate errors easily to the user.Related #9931