Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove wyrm specific icon sass #1063

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Blendify
Copy link
Member

This removes wyrm specific icon sass and migrates fully to using font awesome.

There should be no difference to users

@Blendify Blendify requested review from ericholscher, agjohnson, stsewd and a team February 27, 2021 01:10
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this can be updated and merged after https://github.com/readthedocs/sphinx_rtd_theme/pull/1064/files

@Blendify
Copy link
Member Author

Blendify commented Mar 1, 2021

This pull requests should actually be merged first, I based #1064 on the changes here.

@Blendify
Copy link
Member Author

Blendify commented Mar 1, 2021

I guess the question is if we want to wait for a larger release or not

@stsewd
Copy link
Member

stsewd commented Mar 1, 2021

Got it, I think we should include this together with the other in the same release

@Blendify Blendify added this to the 1.0.0 milestone Mar 11, 2021
@Blendify
Copy link
Member Author

@agjohnson is this change acceptable outside of the wyrm/bootstrap/sphinx2/html4/fontawesome5 changes?

Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to be too careful here, but removing classes that downstream users might have been using should at very least be a breaking change probably.

@@ -1,24 +0,0 @@
.icon
@extend .fa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I maybe have slight concern here about removing the class, in case anyone downstream is using the .icon classes. This might be another backwards incompatible change

@agjohnson agjohnson added Status: blocked Issue is blocked on another issue and removed Status: blocked Issue is blocked on another issue labels Mar 17, 2021
@agjohnson agjohnson modified the milestones: 1.0, 1.1 Mar 17, 2021
@agjohnson
Copy link
Collaborator

I'll target a 1.1 release for now, however I think this probably makes sense in a 2.0 release with a few other backwards incompatible changes before a 3.0 or greater bootstrap release.

@Blendify
Copy link
Member Author

@agjohnson can this go into 1.1?

@benjaoming
Copy link
Contributor

benjaoming commented Aug 27, 2022

Great update, should be merged quickly once we start working on 2.0. We could write alias css classes for .icon-* for backwards compatibility and add a deprecation note in the changelog.

@benjaoming benjaoming modified the milestones: 1.1, 2.0 Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants