NPM: Update to version 7 #1066
Open
NPM: Update to version 7 #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPM made some changes to package.json and package-lock. From what I can tell these changes are backward compatible, see https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json I also moved dependencies that affect the build package to regular dependencies instead of devDependencies. As far as I know this is correct usage and allows developers to easily see what affets the built backage and what affects the devOps process.
stsewd
approved these changes
Mar 1, 2021
|
This is not a user affecting change so it shouldn't matter if it's a big or small release. I do want to break this into two patches though... |
agjohnson
reviewed
Mar 12, 2021
|
This is not related to removing wyrm, the splitting of dev requirements are also not necessary, I meant to update this patch. |
Blendify
commented
Mar 20, 2021
| @@ -17,7 +17,6 @@ | |||
| "url": "https://github.com/readthedocs/sphinx_rtd_theme/issues" | |||
| }, | |||
| "homepage": "https://github.com/readthedocs/sphinx_rtd_theme", | |||
| "dependencies": {}, | |||
There was a problem hiding this comment.
npm7 doesnt like this being empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM made some changes to package.json and package-lock. From what I can
tell these changes are backward compatible, see
https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json
I also moved dependencies that affect the build package to regular
dependencies instead of devDependencies. As far as I know this is
correct usage and allows developers to easily see what affets the built
backage and what affects the devOps process.