Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overflow #626

Merged
merged 1 commit into from
May 1, 2018
Merged

Remove overflow #626

merged 1 commit into from
May 1, 2018

Conversation

davidfischer
Copy link
Contributor

Fixes this issue:

39494888-f3296432-4d4c-11e8-8d75-34e055a2845b

@davidfischer davidfischer mentioned this pull request May 1, 2018
Merged
agjohnson
agjohnson approved these changes May 1, 2018
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure we ever want a scroll there. +1!

@agjohnson agjohnson merged commit f612436 into master May 1, 2018
@agjohnson agjohnson deleted the remove-overflow-y branch May 1, 2018 21:43
@jessetan
Copy link
Contributor

jessetan commented May 2, 2018

I see no harm in having this scrollable in case of many versions (#575), but the extra white space is ugly. I'll see if I can revisit this sometime in the future.

@jessetan jessetan mentioned this pull request May 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidfischer @jessetan @agjohnson